Please stop messing with the html elements and css classes
Tried with default theme: No
Tried with all other plugins disabled: No
Browser version: Chrome 87.0.4280.88
Are you guys aware that a lot of people put a lot of effort in the styling of their website? If you decide to change the css classes it’s a sure way of breaking the design of a website..
Yesterday after updating the plugin on my client’s websites, all designs were broken. After some digging I managed to fix them but it cost me multiple hours..
This morning I started working on the other bug I just submitted and I noticed another update to the plugin. And yet again you decided to put a new html wrapper element somewhere.. Please learn that this breaks stuff and don’t take html / css class changes lightly.
Wrong, not “a lot of people”. Most people do not EVER even touch ARVEs styles.
I changed and improved the CSS with version 9.0 and I will not apologize for it. I do not need to learn anything from you about CSS and HTML believe me. I introduced the new wrapper with 9.1.0 because it gives even more possibilities and I intend to use it in an upcoming add-on that makes videos sticky on scroll. I do NOT take changes lightly only changed the after many years in the new version and when they are necessary.
I would like to see your CSS and what you did exactly anyway because it sounds you may have something to learn, and you may have done the CSS way to specific if a new wrapper that basically just takes the size of its container breaks your design.
Not that I need to justify my actions to you but I changed basically all the CSS and classes in 9.0, so it was going to break customs styles anyway, so I went and simplified the class to make it shorter.
And as I have guessed you need to learn not me. I did NOT change to span do have the elements’ inline, in fact I give them display: block, so they basically act like divs again. Except one key difference. HTML structure. Browsers do not allow div inside p, and they mess around with p and break them up with divs and for the link-lightbox mode of the pro addon I only need to make switch the outer .arve div to span and have it work without browsers messing p structure up. And without having to change all the elements to span just for one mode I went with this by default, so it not gets to messy and complicated. It’s also a good testing ground for me if the output is mostly the same for all people and modes.
You should stop acting like I just to these things to annoy you and for no good reason.
Why would you change a class from ‘arve-embed-container’ to ‘arve-embed’? Just use the old name in your new add-on.
And why change the div to a span? Just display:inline it if you need it inline in your new add-on?
This way everyone’s css will just keep working.
In reply to your last point. I needed the videos to scale and center in specific placed responsive blocks, that’s why they are positioned absolute. And it’s why the wrapper doesn’t take the height of it’s content. So I need to set this new introduced div to 100% height.
You can have a look at the css at http://netwerk.works/